[Bug 784982] x264enc, mpg123audiodec: possible template caps leak
GStreamer (GNOME Bugzilla)
bugzilla at gnome.org
Sat Jul 15 14:03:34 UTC 2017
https://bugzilla.gnome.org/show_bug.cgi?id=784982
Tim-Philipp Müller <t.i.m at zen.co.uk> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
CC| |t.i.m at zen.co.uk
Resolution|--- |FIXED
Target Milestone|git master |1.13.1
Summary|gst-plugins-ugly: Possible |x264enc, mpg123audiodec:
|Memory Leak in in gstcaps |possible template caps leak
Severity|critical |minor
--- Comment #1 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
Thanks, fixed:
commit 58a23c99e932eb4a221673a118d1675fdabd58e2
Author: Tim-Philipp Müller <tim at centricular.com>
Date: Sat Jul 15 14:59:42 2017 +0100
x264enc: fix caps leak
Move creation of supported sink pads into class_init function
which is also the only place where they're used. Unref the
caps when no longer needed, the pad template will take its
own ref.
https://bugzilla.gnome.org/show_bug.cgi?id=784982
commit 841a073154d9ab512b2abba997552b2ae354bc92
Author: Tim-Philipp Müller <tim at centricular.com>
Date: Sat Jul 15 14:57:49 2017 +0100
mpg123audiodec: fix caps leak
The pad template takes its own ref, so we should unref the caps.
https://bugzilla.gnome.org/show_bug.cgi?id=784982
This is not really a problem in practice though since plugins/classes won't get
unloaded after they're created, so it's just for cleanliness really.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list