[Bug 754696] matroskamux: audio-only streams have all buffers flagged as delta units, causing problems with tcpserversink/multifdsink

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=754696

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #355704|none                        |needs-work
             status|                            |

--- Comment #32 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 355704:
 --> (https://bugzilla.gnome.org/review?bug=754696&attachment=355704)

::: gst/matroska/matroska-mux.c
@@ +82,3 @@
 #define  DEFAULT_TIMECODESCALE           GST_MSECOND
+#define  DEFAULT_INTERLEAVE_BYTES        0
+#define  DEFAULT_INTERLEAVE_TIME         0

Maybe the default should be higher, 500ms and 0 bytes maybe?

Also this is not really about interleave, it's about how often to write a "sync
point". I think the bytes property is also not that useful because of that, and
just the time property would be enough.

@@ +359,3 @@
+      g_param_spec_uint64 ("interleave-time", "Interleave (time)",
+          "Interleave between matroska headers/indexes in nanoseconds. A new
matroska "
+          "header will be created irrespetive of this property if max cluster
"

Typo (also in the other property): irrespeCtive

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.