[Bug 784847] omxvideodec: add dmabuf support for zynqultrascaleplus

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=784847

Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #355616|none                        |needs-work
             status|                            |

--- Comment #17 from Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> ---
Review of attachment 355616:
 --> (https://bugzilla.gnome.org/review?bug=784847&attachment=355616)

Looks good overall, but I have one point I don't like.

::: omx/gstomxbufferpool.h
@@ +91,3 @@
 GType gst_omx_buffer_pool_get_type (void);

+GstBufferPool *gst_omx_buffer_pool_new (GstElement * element, GstOMXComponent
* component, GstOMXPort * port, gboolean dmabuf);

I'm not big fan of boolean in API, maybe an enum, something like BUFFER_MODE ?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.