[Bug 784971] matroskamux: Writes one cluster per audio frame

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=784971

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #355788|none                        |committed
             status|                            |

--- Comment #6 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 355788:
 --> (https://bugzilla.gnome.org/review?bug=784971&attachment=355788)

Merged with minor changes, thanks!

::: gst/matroska/matroska-mux.c
@@ +352,3 @@
+      g_param_spec_int64 ("min-cluster-duration", "Minimum cluster duration",
+          "Desidered cluster duration as nanoseconds. A new cluster will be "
+          "created irrispective of this property if a force key unit event "

irrEspective

@@ +3630,3 @@
+  is_max_duration_exceeded = (mux->max_cluster_duration > 0
+      && buffer_timestamp > mux->cluster_time
+      && (buffer_timestamp - mux->cluster_time) > mux->max_cluster_duration);

I made both checks >= mux->mXX_cluster_duration. Otherwise if e.g. exactly
500ms are possible, you always create 500+Xms clusters :)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.