[Bug 785011] videodecoder: Default buffer pool supports GstVideoAlignment but downstream might not

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=785011

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|don't know                  |gst-plugins-base
   Target Milestone|git master                  |1.12.3
            Summary|Sometime between 1.10.4 and |videodecoder: Default
                   |1.12.0 MKV video decode     |buffer pool supports
                   |broke when mapping buffers  |GstVideoAlignment but
                   |to get pixel data           |downstream might not
           Severity|normal                      |blocker

--- Comment #28 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Ok, it's the following code in gstavviddec.c:

>    have_alignment =
>      gst_buffer_pool_has_option (pool, GST_BUFFER_POOL_OPTION_VIDEO_ALIGNMENT);

Which is of course always TRUE if downstream did not provide a pool.
GstVideoBufferPool, which is created by default, always supports that. Just
that downstream might not be able to handle that.

The problem is not the metas but the buffer pool option.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.