[Bug 785011] videodecoder: Default buffer pool supports GstVideoAlignment but downstream might not

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=785011

--- Comment #31 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
(In reply to Carsten Haitzler (Rasterman) from comment #30)
> > Which is of course always TRUE if downstream did not provide a pool. 
> 
> indeed we don't provide a pool. we leave it up to gst to do that... :) aha.
> so that would explain it. must have been added between 1.10 and 1.20 (that
> line). :)

No, you were just lucky before :) But some things changed to make this happen
more likely now it seems.


(In reply to Carsten Haitzler (Rasterman) from comment #29)

> and absolutely the vaapi issue is another ticket. one thing at a time. :)
> reality is i actually want to put in a full zero copy path... but it seems
> pretty involved with gst to do that. well more specifically it kind of
> doesn't quite work with our abstraction.hiding

If you want to discuss this, would be good to get together at the next hackfest
or conference for that :)

> when i get to it i'll file a ticket about vaapi and can go from there.

vaapi should also work with gst_video_frame_map()

> i'll look into the d3dvideosink you point to as well - probably before the
> vaapi stuff

You literally just need to implement those 5 lines of code there. Don't look at
anything else of d3dvideosink, it's not that great :) It was just the first
place that came to my mind that has the GstVideoMeta code implemented.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.