[Bug 784012] decodebin3: Protect dbin->collection with the SELECTION_LOCK

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=784012

Edward Hervey <bilboed at bilboed.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
   Target Milestone|git master                  |1.13.1

--- Comment #5 from Edward Hervey <bilboed at bilboed.com> ---
commit 4b3798fedcd5be1aa76092e91a7d22663100d99f
Author: Thibault Saunier <thibault.saunier at osg.samsung.com>
Date:   Thu Jun 15 12:48:42 2017 -0400

    decodebin3: Protect fields related to streams handling with the
SELECTION_LOCK

    Fields related to stream handling (input_streams,
    output_streams, slots, guint slot_id) where used totally unprotected
    until know.

    This lead to several races, especially playing back RTSP streams.

    To protect those fields, the OBJECT_LOCK can not be used as we sometimes
    need to be able to post message on the bus while holding it.

    decodebin3 already has a lock to manage stream selection, and in the end
    it makes sense to protect all the stream management fields with the same
    lock which is why we reuse the SELECTION_LOCK here.

    https://bugzilla.gnome.org/show_bug.cgi?id=784012

commit 1188345886af566c306c6a9cfe9e08367860bfb1
Author: Edward Hervey <edward at centricular.com>
Date:   Thu Jul 13 17:39:58 2017 +0200

    decodebin3: Protect dbin->collection usage

    Use the selection lock to protect dbin->collection access

    https://bugzilla.gnome.org/show_bug.cgi?id=784012

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.