[Bug 785065] New: encoding:Possible memory leak in gstencodebin.c

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=785065

            Bug ID: 785065
           Summary: encoding:Possible memory leak in gstencodebin.c
    Classification: Platform
           Product: GStreamer
           Version: 1.12.2
                OS: All
            Status: NEW
          Severity: critical
          Priority: Normal
         Component: gst-plugins-base
          Assignee: gstreamer-bugs at lists.freedesktop.org
          Reporter: sp.gupta at samsung.com
        QA Contact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---

Hello All,

There is possible Memory leak in gstencodebin.c

File  : gst-plugins-base/gst/encoding/gstencodebin.c

In function "_create_stream_group" at line: 1258

here srcpad are allocated .

srcpad = gst_element_get_static_pad (sgroup->outqueue, "src");
In case of failure of muxerpad .. it did not unref.. So It might cause possible
memory leak issue.

if (muxerpad) {
    if (G_UNLIKELY (fast_pad_link (srcpad, muxerpad) != GST_PAD_LINK_OK)) {
      goto muxer_link_failure;
    }
    gst_object_unref (muxerpad);
  } else {
    gst_ghost_pad_set_target (GST_GHOST_PAD (ebin->srcpad), srcpad);
  }

Also Same is observed at line 1411.

srcpad must be unref after used.

below documentation also suggest :
https://gstreamer.freedesktop.org/data/doc/gstreamer/head/gstreamer/html/GstElement.html#gst-element-get-static-pad


Solution: There must be   gst_object_unref (srcpad);

Please check and provide your feedback.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.