[Bug 785011] videodecoder: Default buffer pool supports GstVideoAlignment but downstream might not

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=785011

--- Comment #35 from Carsten Haitzler (Rasterman) <raster at rasterman.com> ---
> In addition you probably want to add code like this https://cgit.freedesktop.org/gstreamer/gst-plugins-bad/tree/sys/d3dvideosink/d3dvideosink.c#n466 (without the CROP meta and only until line 470!)

Ahhh a bit more complicated than just a few lines of adding the meta property
things... i have to add the whole propose_allocation thing ... :)we totally
left that alone. would just adding the meta and crop meta (with NULL) then
calling parent class propose alloc be enough? i'd have to look at the
implementation to have a better guess... digging that up may take time. i.e.:

static gboolean
emotion_video_sink_propose_allocation(GstBaseSink *bsink, GstQuery *query)
{
   gst_query_add_allocation_meta(query, GST_VIDEO_META_API_TYPE, NULL);
   gst_query_add_allocation_meta(query, GST_VIDEO_CROP_META_API_TYPE, NULL);

   return GST_CALL_PARENT_WITH_DEFAULT(GST_BASE_SINK_CLASS, propose_allocation,
                                       (bsink, query), TRUE);
}

?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.