[Bug 785065] encodebin: fix possible pad ref leak in error code path

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=785065

Tim-Philipp Müller <t.i.m at zen.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED
   Target Milestone|git master                  |1.13.1
            Summary|encoding:Possible memory    |encodebin: fix possible pad
                   |leak in gstencodebin.c      |ref leak in error code path
           Severity|critical                    |minor

--- Comment #3 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
Thanks for the patch, but it's not quite complete.

There's a compiler warning about how srcpad might be used uninitialized, and we
should also reset srcpad to NULL when we do properly unref it in the code, so
that we don't accidentally unref it twice when we hit an error.

I've fixed it up a bit and pushed it:

commit 3cc824c9cef76c93c3318f3691f8a51ba7c8f9c3
Author: Satya Prakash Gupta <sp.gupta at samsung.com>
Date:   Wed Jul 19 09:02:26 2017 +0530

    encodebin: fix possible pad ref leak in error code path

    https://bugzilla.gnome.org/show_bug.cgi?id=785065

-- 
You are receiving this mail because:
You are the QA Contact for the bug.