[Bug 784590] encoder: h264: Performance tuning for specific platforms

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=784590

Víctor Manuel Jáquez Leal <vjaquez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #354985|none                        |reviewed
             status|                            |

--- Comment #4 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
Review of attachment 354985:
 --> (https://bugzilla.gnome.org/review?bug=784590&attachment=354985)

::: gst-libs/gst/vaapi/gstvaapiencoder_h264.c
@@ +98,3 @@
+      {GST_VAAPI_ENCODER_H264_COMPLIANCE_MODE_RESTRICT_CODED_BUFFER_ALLOC,
+            "Restict the allocation size of coded-buffer",
+          "restrict-buf-alloc"}

the array needs a null structure
{0,NULL,NULL}

otherwise the code might crash

@@ +2925,3 @@
+  if (encoder->compliance_mode ==
+      GST_VAAPI_ENCODER_H264_COMPLIANCE_MODE_RESTRICT_CODED_BUFFER_ALLOC)
+    base_encoder->codedbuf_size /= encoder->min_cr;

I don't like having a property for this. 

would be possible to query the driver to know if this is required, avoiding the
property?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.