[Bug 784599] kmssink: support videooverlay interface

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Wed Jul 19 11:09:25 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=784599

--- Comment #20 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
(In reply to Haihua Hu from comment #19)
> (In reply to Víctor Manuel Jáquez Leal from comment #17)
> > Review of attachment 355380 [details] [review] [review]:
> > 
> 
> Thanks for your comments.
> 
> > ::: sys/kms/gstkmssink.c
> > @@ +358,3 @@
> > +  if (result) {
> > +    self->can_scale = FALSE;
> > +    GST_INFO_OBJECT (self, "scale is not support");
> > 
> > I don't like the idea of showing an empty (green?) frame to the user at
> > start. Can we delay the expose call until the first show_frame() is called.
> 
> Is there any other way to check whether driver support scale or not? Why
> delay expose can fix this problem?

As far as I understand, the element will know if the driver supports scale
after the first _show_frame() call.

I guess, somehow _expose() will call first _show_frame() and then it will know
if the driver can scale.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list