[Bug 784295] timecodestamper: LTC from audio

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=784295

--- Comment #5 from Vivia Nikolaidou <vivia at ahiru.eu> ---
Issue found:

Currently, in the LTC chain function, if the timecode source isn't LTC, it's
waiting there forever in the g_cond. That fills up all queues upstream,
blocking us from receiving any further events and forcing us to sit on the
stream lock all the time. That can actually lead to deadlocks.

This fixes it for me:

diff --git a/gst/timecode/gsttimecodestamper.c
b/gst/timecode/gsttimecodestamper.c
index 27ca99979..fe3493108 100644
--- a/gst/timecode/gsttimecodestamper.c
+++ b/gst/timecode/gsttimecodestamper.c
@@ -732,6 +732,9 @@ gst_timecodestamper_ltcpad_chain (GstPad * pad,
   if (!timecodestamper->vinfo.fps_n || !timecodestamper->vinfo.fps_d)
     goto beach;

+  if (timecodestamper->tc_source != GST_TIME_CODE_STAMPER_LTC)
+    goto beach;
+
   g_mutex_lock (&timecodestamper->ltc_mutex);

   brt = gst_segment_to_running_time (&timecodestamper->ltc_segment,

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.