[Bug 753323] mpegts: add support for JPEG 2000 to mpegtsmux and tsdemux

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=753323

--- Comment #124 from Aaron Boxer <boxerab at gmail.com> ---
(In reply to Sebastian Dröge (slomo) from comment #121)
> (In reply to Aaron Boxer from comment #118)
> 
> > Also, I am not sure how to handle the frame number issue - Milos had some
> > problems with the frame number, but I am not clear on what they were.
> > Perhaps this was a rounding issue, which we have fixed by using 64 bit
> > intermediate variables ?
> 
> My point here is that this is a timecode, not a timestamp :) You need to use
> the GstVideoTimeCode API for doing anything meaningful here, which would
> also make any rounding issues disappear

Thanks, will take a look.

> 
> (In reply to Aaron Boxer from comment #120)
> 
> > > Is a fixed framerate required, or can it be 0/1 or 0/0?

>From what I can see, frame rate is fixed, so 0/0 is not allowed. Also,
frame rate of 0 is not allowed according to spec, so 0/1 also not allowed.


> > 
> > 
> > Not sure if frame rate is fixed. What does 0/1 and 0/0 mean ?
> 
> 0/0 is invalid in GStreamer, but would be what you set here if there is no
> framerate provided by GStreamer. What does the spec say about this?
> 
> 0/1 is GStreamer's way of saying "this is variable framerate". What does the
> spec say about variable framerate?
> 
> Related to that, is the timecode box optional? Because timecodes make no
> sense for variable framerate streams


Time code box is mandatory. So, pretty sure that framerate is fixed.
>From spec, range for time code is:

HH (0-23)
MM (0-59)
SS (0-59)
FF (1-60)

> 
> > > 
> > > @@ +842,3 @@
> > > +          color_spec = 3;
> > > +        } else {
> > > +          color_spec = 1;       /* RGB as default */
> > > 
> > > What is it that is these values mean? Color range, primaries, matrix, gamma
> > > transfer function, all at once? You might want to use
> > > gst_video_colorimetry_from_string() and then look specifically at the struct
> > > returned
> > 
> > I think the color spec indicates the colour space.
> 
> What does the spec say exactly for these values? You probably want color
> primaries or the matrix here then.

Colour spec is described in a different document that I don't have access to.
But I do know the following:

sRGB 0x01
Rec-601 0x02
Rec-709 0x03
CIE-LUV 0x04
CIE-XYZ 0x05
Rec-2020 0x06
SMPTE-2084 0x07

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.