[Bug 785112] Freeing NONHEAP_MEMORY.STRING
GStreamer (GNOME Bugzilla)
bugzilla at gnome.org
Mon Jul 24 04:57:45 UTC 2017
https://bugzilla.gnome.org/show_bug.cgi?id=785112
--- Comment #9 from Ashish Kumar <kr.ashish at samsung.com> ---
(In reply to Sebastian Dröge (slomo) from comment #7)
> Well, is your patch going to be correct? It seems like there's nothing to be
> changed here
It can be corrected if we remove below code segment which is redundant :-
LnNo.198 if (param_name)
LnNo.199 tmp = param_name;
LnNo.200 else
LnNo.201 tmp = (char *) "";
as
LnNo.101 gchar *param_name = NULL;
and is not assigned anything till
LnNo.204 param_name = g_strdup_printf ("%s\\n%s=%s", tmp, property->name,
value_str);
Also we can modify the statements at LnNo. 204 and 207 as like below:
param_name = g_strdup_printf ("\\n%s=%s",property->name,
value_str);
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list