[Bug 785029] kmssink: Add dumb buffer support for driver pitch with multi planar formats

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Tue Jul 25 09:12:33 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=785029

Guillaume Desmottes <gdesmott at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #356320|none                        |needs-work
             status|                            |

--- Comment #9 from Guillaume Desmottes <gdesmott at gnome.org> ---
Review of attachment 356320:
 --> (https://bugzilla.gnome.org/review?bug=785029&attachment=356320)

::: sys/kms/gstkmsallocator.c
@@ +198,3 @@
+
+    offs +=
+      continue;

This is not working on my platform. Shouldn't we pass the frame height as 3rd
argument?
If I pass GST_VIDEO_INFO_HEIGHT then it works.

@@ +209,2 @@
   kmsmem->bo->handle = arg.handle;
+  /* will be used a memory maxsize */

"as memory maxsize"

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list