[Bug 784599] kmssink: support videooverlay interface

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=784599

--- Comment #22 from Haihua Hu <jared.hu at nxp.com> ---
(In reply to Víctor Manuel Jáquez Leal from comment #20)
> (In reply to Haihua Hu from comment #19)
> > (In reply to Víctor Manuel Jáquez Leal from comment #17)
> > > Review of attachment 355380 [details] [review] [review] [review]:
> > > 
> > 
> > Thanks for your comments.
> > 
> > > ::: sys/kms/gstkmssink.c
> > > @@ +358,3 @@
> > > +  if (result) {
> > > +    self->can_scale = FALSE;
> > > +    GST_INFO_OBJECT (self, "scale is not support");
> > > 
> > > I don't like the idea of showing an empty (green?) frame to the user at
> > > start. Can we delay the expose call until the first show_frame() is called.
> > 
> > Is there any other way to check whether driver support scale or not? Why
> > delay expose can fix this problem?
> 
> As far as I understand, the element will know if the driver supports scale
> after the first _show_frame() call.

Hi, this is not correct. If the original video size is equal to display size.
The first setplane try will not fail. As a result, the can_scale will be true
even if the drm driver don't support scale. We should make sure the can_scale
be correct when start.

> 
> I guess, somehow _expose() will call first _show_frame() and then it will
> know if the driver can scale.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.