[Bug 785429] wavparse: Fixed memory leak in gstwavparse.c

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Wed Jul 26 11:59:30 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=785429

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #356411|none                        |needs-work
             status|                            |

--- Comment #3 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 356411:
 --> (https://bugzilla.gnome.org/review?bug=785429&attachment=356411)

The format of the commit message is still wrong, it should be:

elementname-or-component: short summary what is fixed
[empty line]
Long description if needed
[empty line]
https://link.to/this/bug

::: gst/wavparse/gstwavparse.c
@@ +237,3 @@
   wav->labls = NULL;
+  if (wav->notes)
+    g_list_free_full (wav->notes, g_free);

This is leaking the text field of the GstWavParseNote structs

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list