[Bug 732267] h264parse: extract base stream from MVC or SVC encoded streams

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=732267

--- Comment #7 from Orestis Floros <orestisf1993 at gmail.com> ---
(In reply to Víctor Manuel Jáquez Leal from comment #6)
> Review of attachment 356212 [details] [review]:
> 
> ::: gst/videoparsers/gsth264parse.c
> @@ +225,3 @@
>    h264parse->align = GST_H264_PARSE_ALIGN_NONE;
>    h264parse->format = GST_H264_PARSE_FORMAT_NONE;
> +  h264parse->base_only = FALSE;
> 
> as 0 is the default value, there's not much need to add this assignation

but everything else is initialized.

> 
> @@ +721,3 @@
> +  caps = gst_caps_new_empty_simple ("video/x-h264");
> +  gst_caps_set_simple (caps, "profile", G_TYPE_STRING, profile_str, NULL);
> +  return ensure_caps_profile (h264parse, caps, sps);
> 
> wouldn't be simpler just call gst_caps_can_intersect() here?

I call ensure_caps_profile() to also check for the compatible profiles.

I can simplifiy with a single call to gst_caps_new_simple() though.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.