[Bug 783169] Don't try to load vaapi and fail

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=783169

Víctor Manuel Jáquez Leal <vjaquez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #354863|none                        |needs-work
             status|                            |

--- Comment #5 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
Review of attachment 354863:
 --> (https://bugzilla.gnome.org/review?bug=783169&attachment=354863)

Thanks for the patch, but the fix is not acceptable as is, because it can lead
to crashes. Though, your explanation of the issue seems correct, we should look
for another fix :)

::: gstreamer-vaapi-1.12.1/gst/vaapi/gstvaapipluginutil.c
@@ +126,3 @@
+      }
+    } else {
+      g_setenv ("GST_GL_WINDOW", required, 1);

You shouldn't call setenv in mutithreaded code:

http://rachelbythebay.com/w/2017/01/30/env/

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.