[Bug 785429] wavparse: Fixed memory leak in gstwavparse.c

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Thu Jul 27 11:19:32 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=785429

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #356454|none                        |needs-work
             status|                            |

--- Comment #5 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 356454:
 --> (https://bugzilla.gnome.org/review?bug=785429&attachment=356454)

::: gst/wavparse/gstwavparse.c
@@ +237,3 @@
   wav->labls = NULL;
+  if (wav->notes)
+    g_list_free_full (wav->notes, g_free);

This still leaks the text field of those structs. Note that the text field of
the labls is also leaked above already... if you want to send a patch for that
one too

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list