[Bug 784779] gl: public gstgl headers should not include GL headers

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=784779

--- Comment #10 from Julien Isorce <julien.isorce at gmail.com> ---
(In reply to Matthew Waters (ystreet00) from comment #7)
> Review of attachment 355741 [details] [review]:
> 
> Ok there seems to a mismatch on the expected behaviour.  gst/gl/gl.h is the
> top-level header for everybody to include and is also the single include
> used for gobject-introspection as #include-ing random gstgl headers has
> gotten us into trouble before (the glmemory includes are specially crafted)
> so changing that behaviour to require this scenario for not using GL
> types/functions probably isn't wise.
> 
> I think the best route is that gst/gl/gstglfuncs.h should not be #include-d
> in gst/gl/gl.h 

Done in patch i just attached patch "gl: remove include of gstglfuncs.h from
gst/gl/gl.h" 
I keep it split so that we can see the diff. But the plan is to squash it.

> The added typedef's are also problematic if the type doesn't match the
> system provided headers and/or GL/gl.h or GLES2/gl2.h aren't in system paths.

typedef void *EGLImageKHR;
typedef void *EGLSurface;
typedef void *EGLContext;
typedef void *EGLDisplay;

Yup I am not sure, note that this is only for egl and are not platform
dependent, i.e. not in eglplatform.h . So this should be always void* .

> +typedef void *EGLImageKHR;
> 
> This may cause redefinition type warnings.  What's the plan for dealing with
> these?

The best I can do is to guard it with #ifndef / #endif

> The added test looks good.

Cool! \o/

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.