[Bug 785112] Freeing NONHEAP_MEMORY.STRING

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=785112

--- Comment #16 from Ashish Kumar <kr.ashish at samsung.com> ---
(In reply to Ashish Kumar from comment #15)
> (In reply to Sebastian Dröge (slomo) from comment #13)
> > Review of attachment 356344 [details] [review] [review]:
> > 
> > ::: gst/gstdebugutils.c
> > @@ +198,2 @@
> >          if (details & GST_DEBUG_GRAPH_SHOW_FULL_PARAMS) {
> > +          param_name = g_strdup_printf ("\\n%s=%s", property->name,
> > 
> > This is changing behaviour. You're not prefixing with the property_name
> > anymore. Also below
> 
> ----------------------------------
> In the original code 'property->name' is always prefixed by an empty string
> as 'tmp' is always assigned empty string ""
> ------------------
> LnNo.198        if (param_name)     //'param_name' always 'NULL' here
> LnNo.199          tmp = param_name; //control never reaches here
> LnNo.200        else
> LnNo.201          tmp = (char *) "";
> LnNo.202
> LnNo.203        if (details & GST_DEBUG_GRAPH_SHOW_FULL_PARAMS) {
> LnNo.204          param_name = g_strdup_printf ("%s\\n%s=%s", tmp,
> property->name,
> LnNo.205              value_str);
> LnNo.206        } else {
> LnNo.207          param_name = g_strdup_printf ("%s\\n%s=%."
> LnNo.208              G_STRINGIFY (PARAM_MAX_LENGTH) "s%s", tmp,
> property->name,
> LnNo.209              value_str, ellipses);
> LnNo.210        }
> 
> Removing prefixing of 'property->name' by an empty string should not make
> any difference.
> But, if it is still changing the behaviour, please review the new patch
> attached in which 'property->name' is prefixed with an empty string.

@Mr. Sebastian
Have you reviewed?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.