[Bug 785628] New: Build failure on 32-bit ARM in gstv4l2object.c

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=785628

            Bug ID: 785628
           Summary: Build failure on 32-bit ARM in gstv4l2object.c
    Classification: Platform
           Product: GStreamer
           Version: git master
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: Normal
         Component: gst-plugins-good
          Assignee: gstreamer-bugs at lists.freedesktop.org
          Reporter: kirill.novichikhin at sarov-itc.ru
        QA Contact: gstreamer-bugs at lists.freedesktop.org
                CC: nicolas at ndufresne.ca
     GNOME version: ---

Created attachment 356640
  --> https://bugzilla.gnome.org/attachment.cgi?id=356640&action=edit
One possible way to fix the build

This is a Yocto build of master branch at
317d3380bbee24763dfeec4bbb9d1c733e519aff (common at
48a5d85ebf4a0bad1c997c83100f710fe2154fbf)

| arm-poky-linux-gnueabi-libtool: compile:  arm-poky-linux-gnueabi-gcc
-march=armv7-a -marm -mfpu=neon -mfloat-abi=hard -mcpu=cortex-a9
--sysroot=/home/user/fsl-community-bsp-2.2/build/tmp/sysroots/wandboard
-DHAVE_CONFIG_H -I. -I../../../git/sys/v4l2 -I../.. -pthread
-I/home/user/fsl-community-bsp-2.2/build/tmp/sysroots/wandboard/usr/include/gstreamer-1.0
-I/home/user/fsl-community-bsp-2.2/build/tmp/sysroots/wandboard/usr/include/glib-2.0
-I/home/user/fsl-community-bsp-2.2/build/tmp/sysroots/wandboard/usr/lib/glib-2.0/include
-pthread
-I/home/user/fsl-community-bsp-2.2/build/tmp/sysroots/wandboard/usr/include/gstreamer-1.0
-I/home/user/fsl-community-bsp-2.2/build/tmp/sysroots/wandboard/usr/include/glib-2.0
-I/home/user/fsl-community-bsp-2.2/build/tmp/sysroots/wandboard/usr/lib/glib-2.0/include
-I../../../git/gst-libs -pthread
-I/home/user/fsl-community-bsp-2.2/build/tmp/sysroots/wandboard/usr/include/gstreamer-1.0
-I/home/user/fsl-community-bsp-2.2/build/tmp/sysroots/wandboard/usr/include/glib-2.0
-I/home/user/fsl-community-bsp-2.2/build/tmp/sysroots/wandboard/usr/lib/glib-2.0/include
-DGST_USE_UNSTABLE_API -DG_THREADS_MANDATORY -DG_DISABLE_DEPRECATED -Wall
-Wdeclaration-after-statement -Wvla -Wpointer-arith -Wmissing-declarations
-Wmissing-prototypes -Wredundant-decls -Wwrite-strings -Wold-style-definition
-Waggregate-return -Winit-self -Wmissing-include-dirs -Waddress -Wno-multichar
-Wnested-externs -Werror -DGST_DISABLE_DEPRECATED
-I/home/user/fsl-community-bsp-2.2/build/tmp/sysroots/wandboard/usr/include/gudev-1.0
-I/home/user/fsl-community-bsp-2.2/build/tmp/sysroots/wandboard/usr/include/glib-2.0
-I/home/user/fsl-community-bsp-2.2/build/tmp/sysroots/wandboard/usr/lib/glib-2.0/include
-O2 -pipe -g -feliminate-unused-debug-types
-fdebug-prefix-map=/home/user/fsl-community-bsp-2.2/build/tmp/work/cortexa9hf-neon-mx6qdl-poky-linux-gnueabi/gstreamer1.0-plugins-good/1.13+gitAUTOINC+317d3380bb-r0=/usr/src/debug/gstreamer1.0-plugins-good/1.13+gitAUTOINC+317d3380bb-r0
-fdebug-prefix-map=/home/user/fsl-community-bsp-2.2/build/tmp/sysroots/x86_64-linux=
-fdebug-prefix-map=/home/user/fsl-community-bsp-2.2/build/tmp/sysroots/wandboard=
-c ../../../git/sys/v4l2/gstv4l2object.c  -fPIC -DPIC -o
.libs/libgstvideo4linux2_la-gstv4l2object.o
| ../../../git/sys/v4l2/gstv4l2object.c: In function 'gst_v4l2_object_new':
| ../../../git/sys/v4l2/gstv4l2object.c:512:22: error: assignment from
incompatible pointer type [-Werror=incompatible-pointer-types]
|      v4l2object->mmap = mmap;
|                       ^

Last argument to mmap is __off_t, which is unsigned long. Last argument to
v4l2_mmap is uint64_t. This mismatch breaks build on 32-bit platforms

Attached: a patch I used to work around the issue, not sure if this should be
ifdef'ed on 32-bit platforms or left to the compiler to eliminate.

Alternative patch could use mmap2 to allow for more addressable space if
necessary.

Assumed regression after commit 31d8a1d929fecd7ceaa7575be5921f9148ed8afb

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.