[Bug 766832] encoder: Add CBR and VBR support in VP9

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=766832

--- Comment #6 from Hyunjun Ko <zzoon at igalia.com> ---
(In reply to Víctor Manuel Jáquez Leal from comment #5)
> Review of attachment 352508 [details] [review]:
> 
> @@ +313,3 @@
> +    rate_control->window_size = encoder->cpb_length;
> +    rate_control->initial_qp = encoder->yac_qi;
> +    rate_control->min_qp = 1;   /* Fixme: provide user control */
> 
> I not sure if 1 is a good "default". vp9enc uses 0. Also ffmpeg, if I
> understand correctly.
> 

It's ok to set 0 as default. But I doubt even driver is handling this parameter
for VP8/VP9 encoding, especially for CBR/VBR.
As you said, bitrate and target percentage is important in this case.
Sree may know about this in detail :)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.