[Bug 777825] isoff: Move isoff to gst-libs

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Fri Jun 2 20:27:33 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=777825

Reynaldo H. Verdejo Pinochet <reynaldo at osg.samsung.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #352029|none                        |accepted-commit_now
             status|                            |

--- Comment #35 from Reynaldo H. Verdejo Pinochet <reynaldo at osg.samsung.com> ---
Review of attachment 352029:
 --> (https://bugzilla.gnome.org/review?bug=777825&attachment=352029)

Looks good to me.

::: ext/smoothstreaming/gstmssfragmentparser.c
@@ +41,3 @@
 {
+  if (parser->moof)
+    gst_isoff_moof_box_free (parser->moof);

Can you think of a reason why not making the _box_free () functions NULL-safe?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list