[Bug 783330] navigation: Add introspection annotations for some output parameters

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=783330

Arun Raghavan <arun at arunraghavan.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |arun at arunraghavan.net

--- Comment #4 from Arun Raghavan <arun at arunraghavan.net> ---
(In reply to Scott D Phillips from comment #3)
> (In reply to Arun Raghavan from comment #1)
> > Review of attachment 353029 [details] [review] [review]:
> > 
> > Thanks for this -- could you also add (optional) to the parameters which are
> > ignored if NULL? (I don't see any that should also be (nullable), but do
> > double check).
> 
> The only place that seemed like it could conceivable be nullable is key from
> gst_navigation_event_parse_key_event. It seems more like a logic error
> though so I left nullable off. Seem ok?

This one's a bit awkward indeed -- I think we should either add some validation
while creating the event, so we can be a bit more resilient to errors (and then
we can skip the nullable). I'll do that after pushing out your fixes. Thanks!

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.