[Bug 783417] Add physical memory allocator base class in badallocator

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=783417

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #353161|none                        |reviewed
             status|                            |

--- Comment #3 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 353161:
 --> (https://bugzilla.gnome.org/review?bug=783417&attachment=353161)

::: gst-libs/gst/allocators/gstallocatorphymem.h
@@ +40,3 @@
+  guint8 *caddr;
+  gsize size;
+  gpointer *user_data;

This is all very specific to how things work on imx6. As such it should live in
some imx6 specific library, probably just stay in the gstreamer-imx (
https://github.com/Freescale/gstreamer-imx/ ) repository and be installed as a
library from there. The reason why I went with an interface instead of an
actual allocator is that this is always going to be very platform specific, and
there's probably not going to be much common functionality to share.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.