[Bug 742918] v4l2: Add decoder and converter element with RW device property

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=742918

Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #353246|none                        |needs-work
             status|                            |

--- Comment #27 from Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> ---
Review of attachment 353246:
 --> (https://bugzilla.gnome.org/review?bug=742918&attachment=353246)

::: sys/v4l2/gstv4l2videoenc.c
@@ +326,3 @@
   outcaps = gst_caps_make_writable (outcaps);
+  outcaps = gst_pad_peer_query_caps (encoder->srcpad, outcaps);
+  outcaps = gst_caps_fixate (outcaps);

This is obscure change. Each subclass of GstV4l2VideoEnc should have been
created with a single template. So for the H264 subclass the template caps
should simply be "video/x-h264,stream-format=byte-stream". The downstream query
is also redundant, because this will be done few lines later, when we call
gst_video_encoder_negotiated() (see negotiate() virtual method). The actual set
format will happen at the start of decide_allocation().

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.