[Bug 698657] shm: Port shared memory plugin to Windows

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=698657

--- Comment #19 from Olivier Crête <olivier.crete at ocrete.ca> ---
Review of attachment 245588:
 --> (https://bugzilla.gnome.org/review?bug=698657&attachment=245588)

::: sys/shm/gstshmsrc.c
@@ +162,3 @@
 gst_shm_src_init (GstShmSrc * self)
 {
+  self->socket_port = DEFAULT_PORT;

#ifdef G_OS_WIN32

::: sys/shm/gstshmsrc.h
@@ +50,2 @@
   gchar *socket_path;
+  guint socket_port;

This one should be ifdef'ed out

::: sys/shm/shmpipe.h
@@ +89,3 @@
 ShmPipe *sp_writer_create (const char *path, size_t size, mode_t perms);
+#else
+ShmPipe *sp_writer_create (unsigned int port, size_t size);

If the API is different, may as well call the function
sp_writer_create_win32().

@@ +125,3 @@
 ShmPipe *sp_client_open (const char *path);
+#else
+ShmPipe *sp_client_open (unsigned int port);

If the API is different, may as well call the function sp_client_open_win32().

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.