[Bug 783521] gl: Add "direct" dmabuf uploader

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=783521

--- Comment #4 from Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> ---
Review of attachment 353352:
 --> (https://bugzilla.gnome.org/review?bug=783521&attachment=353352)

Looks overall good, I don't think the probing of color format is a blocker, but
the list is a bit small. We just need something for the caching, which I
believe could be solved by using external texture target. That would slow down
redraw, but it's minor thing for video streaming.

::: gst-libs/gst/gl/gstglupload.c
@@ +36,3 @@
 #if GST_GL_HAVE_DMABUF
 #include <gst/allocators/gstdmabuf.h>
+#include <libdrm/drm_fourcc.h>

Not used, at least not in this file.

@@ +636,3 @@
+     * block below. */
+#if 1
+    dmabuf->eglimage = NULL;

Comment out the entire thing, otherwise compilers may warn. We could also add a
getenv hack here to disable that. My research this week led that assuming the
texture will be refreshed is undefined with TEXTURE_2D, did you experiment with
EXTERNAL texture ?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.