[Bug 783307] rtspsrc: uniquify stream ids

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Wed Jun 7 21:45:52 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=783307

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #352976|committed                   |needs-work
             status|                            |

--- Comment #5 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 352976:
 --> (https://bugzilla.gnome.org/review?bug=783307&attachment=352976)

::: gst/rtsp/gstrtspsrc.c
@@ +1509,3 @@
+  gchar *stream_id = g_strdup_printf ("%s%d%d%s%d", media->media, media->port,
+      media->num_ports, media->proto, stream->default_pt);
+  gchar *res = g_compute_checksum_for_string (G_CHECKSUM_MD5, stream_id, -1);

That's not really a reason, please don't use a checksum here as it makes
debugging harder. There's nothing disallowing usage of / in stream IDs, but
feel free to just replace / with some other character if it annoys you too
much.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list