[Bug 783532] New: encoder: regression in CBR mode encode

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=783532

            Bug ID: 783532
           Summary: encoder: regression in CBR mode encode
    Classification: Platform
           Product: GStreamer
           Version: unspecified
                OS: Linux
            Status: NEW
          Severity: major
          Priority: Normal
         Component: gstreamer-vaapi
          Assignee: gstreamer-bugs at lists.freedesktop.org
          Reporter: bsreerenj at gmail.com
        QA Contact: gstreamer-bugs at lists.freedesktop.org
                CC: bsreerenj at gmail.com, vjaquez at igalia.com
     GNOME version: ---

The recent patches seems to brought a huge regression in BRC.

Driver is generating the warning "WARNING: Rate control parameter is required
for BRC" , which basically disabling the BRC algorithms.

Probably the last three commits:

commit f8afb1eea475d2d77b5b660609a0f02da401636f
Author: Víctor Manuel Jáquez Leal <vjaquez at igalia.com>
Date:   Wed Jun 7 12:32:53 2017 +0200

    libs: encoder: bitrate target percentage calculation

    If the rate control is set to Constant Bit Rate (CBR) the target
    percentage is 100%, otherwise is 70%

commit 4b5ecca29c81d0219d83d3271c1aa5e25c3673d8
Author: Víctor Manuel Jáquez Leal <vjaquez at igalia.com>
Date:   Wed Jun 7 12:25:24 2017 +0200

    libs: encoder: h264,h265,mpeg2,vp8,vp9: refactor ratecontrol param

    Centralize the common configuration for the Rate Control parameter,
    thus can be overloaded per each specific encoder.

commit 035efded759e181ec8591fc360758530bb757446
Author: Víctor Manuel Jáquez Leal <vjaquez at igalia.com>
Date:   Wed Jun 7 11:10:49 2017 +0200

    libs: encoder: h264,h265,mpeg2,vp8,vp9: refactor framerate param

    Since the framerate VA parameter is calculated equally among all the
    encoders, it is better to handle it in the base encoder class.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.