[Bug 783291] filesrc ! openjpegdec fails on JP2 image

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=783291

--- Comment #5 from Vincent Penquerc'h <vincent.penquerch at collabora.co.uk> ---
As far as I can tell, the reason is that openjpegdec specifically asks to only
get used if the media type of the incoming data is known
(gst_video_decoder_set_needs_format (decoder, TRUE);). With filesrc, it is not,
since it's ANY caps. I traced into the code thinking it was a bug somewhere
which was skipping negotiation, but I now think it's as intended. If a typefind
element is inserted after filesink, that error is now gone, though openjpegdec
fails to decode the data (I'm not sure whether it's supposed to be able to
decode that particular variant).


I pushed a couple things I found while investigating too:

commit 903684aa78787f90ba95355ebc90d58bb31ce7a0
Author: Vincent Penquerc'h <vincent.penquerch at collabora.co.uk>
Date:   Wed Jun 7 16:17:50 2017 +0100

    openjpeg: guard against invalid memory access on crafted files

commit e5a0c4a751383145d6a5da4e1912d21f41c5e575
Author: Vincent Penquerc'h <vincent.penquerch at collabora.co.uk>
Date:   Mon Jun 5 15:31:52 2017 +0100

    jpeg2000sampling: fix critical when sampling is missing from caps

    This can happen with real files

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.