[Bug 783567] Encode: Fix the hardcoded range of quality level

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=783567

--- Comment #2 from sreerenj <bsreerenj at gmail.com> ---
Hm actually there is a bit of problem here.!
All 1.8.x series driver are returning a max val of 8 and
https://github.com/01org/intel-vaapi-driver/pull/194/files patch going to
change it to 7.

For gstreaemr-vaapi the below codeo will case issues
GST_VAAPI_ENCODER_QUALITY_LEVEL (encoder) =
        gst_util_uint64_scale_int_ceil (GST_VAAPI_ENCODER_QUALITY_LEVEL
        (encoder), quality_level_max, 7);

May be it is more better to use 8 in the gst_util_uint64_scale_int_ceil(),
but encoder property should advertise the max val as 7.

Otherwise,

Users having driver-1.8.x are going end up in trouble by setting 8 as quality
level:
8*8/8 = 8

On the other hand, if we keep 7 as hard-coded value as in patch,
Users having driver-1.8.x are going to end up in trouble by setting 7 as
quality level:
7*8/7 = 8

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.