[Bug 783675] queue2: Deadlock in Queue2 when music streaming plays long time.

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=783675

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #353596|none                        |reviewed
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 353596:
 --> (https://bugzilla.gnome.org/review?bug=783675&attachment=353596)

::: plugins/elements/gstqueue2.c
@@ +2967,2 @@
     g_atomic_int_set (&queue->downstream_may_block, 0);
+    GST_QUEUE2_MUTEX_UNLOCK (queue);

This is atomically set, so no mutex is needed as long as the other usage of
that variable is correctly done with atomic operations too. Is it not?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.