[Bug 783521] gl: Add "direct" dmabuf uploader

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Tue Jun 13 04:43:58 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=783521

Matthew Waters (ystreet00) <ystreet00 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #353349|none                        |needs-work
             status|                            |

--- Comment #5 from Matthew Waters (ystreet00) <ystreet00 at gmail.com> ---
Review of attachment 353349:
 --> (https://bugzilla.gnome.org/review?bug=783521&attachment=353349)

Not quite.

::: gst-libs/gst/gl/gstglmemory.c
@@ +1459,2 @@
   g_return_val_if_fail (!wrapped_data
+      || n_mem >= n_wrapped_pointers, FALSE);

This should be a == and should still include the views multiplication.

The number of wrapped pointers must be equivalent to the number of memory
blocks.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list