[Bug 783625] typefinding: add support for jpc or j2c

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=783625

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #353647|none                        |reviewed
             status|                            |

--- Comment #10 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 353647:
 --> (https://bugzilla.gnome.org/review?bug=783625&attachment=353647)

::: gst/typefind/gsttypefindfunctions.c
@@ +3205,3 @@
+
+  /* SOC marker + SIZ marker */
+  if (memcmp (data, "\377\117\377\121", 4) != 0)

If this is all you want to test, you could use the
TYPE_FIND_REGISTER_START_WITH() macro :)

What you could add in addition here is for example to return a lower
probability if you only find SOC/SIZ, and if you find afterwards one of the
other markers (after skipping markers by size), increase the probability.


Also I don't think we need a typefinder for the JPEG2000 codestream with the
MP4 box in front of it, it's nothing that should appear outside of MP4/MOV
files.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.