[Bug 783726] vaapi: failure of some tcs in gst-validate-launcher

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=783726

Víctor Manuel Jáquez Leal <vjaquez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #353656|none                        |reviewed
             status|                            |

--- Comment #3 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
Review of attachment 353656:
 --> (https://bugzilla.gnome.org/review?bug=783726&attachment=353656)

::: gst-libs/gst/vaapi/gstvaapidecoder_h264.c
@@ +3187,3 @@
+  prev_picture =
+      prev_frame ? gst_vaapi_picture_ref (prev_frame->buffers[0]) : NULL;
+

These kind of patches are worrisome, since they, by catching NULLs are just
hiding the original problem: why that NULL appears?

IMO the regression needs to complete the patch that didn't foresee this
situation where there is no previous frame.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.