[Bug 783829] omxh264enc: unclear 'interval-intraframes' property

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=783829

--- Comment #3 from Guillaume Desmottes <gdesmott at gnome.org> ---
(In reply to Nicolas Dufresne (stormer) from comment #1)
> (In reply to Guillaume Desmottes from comment #0)
> > The omxh264enc element has this property:
> > 
> >   interval-intraframes: Interval of coding Intra frames
> > (0xffffffff=component default)
> > 
> > If set, it will override the OMX_VIDEO_CONFIG_AVCINTRAPERIOD.nPFrames
> > setting (section 4.3.27 in the spec,
> > https://www.khronos.org/registry/OpenMAX-IL/specs/
> > OpenMAX_IL_1_1_2_Specification.pdf ) which is defined as:
> > "nPFrames specifies coding of a frame as Intra (non-inclusive of the first
> > frame)
> > after every nPFrames of Inter frames."
> > So the number of P frames between each I frame basically.
> 
> No, it says as Intra. Which means on how many P-Frames the keyframe will be
> encoded into. In intra-refresh, we remove key-frame and add some key line to
> each delta frames. This interval should control how many P-Frame a decoder
> will need before it gets a complete image when starting from scratch or
> after data lost.

Where did you see that this setting was related to intra-refresh? The specs
says:

"The OMX_VIDEO_CONFIG_AVCINTRAPERIOD structure is used to enable and
configure the IDR and Intra periodicity for the AVC encoder during an encoding
session."

I don't see anything related to intra-refresh there.
That's the job of OMX_VIDEO_PARAM_INTRAREFRESHTYPE (and
OMX_CONFIG_INTRAREFRESHVOPTYPE) which has settings to control intra-refresh
parameters.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.