[Bug 783862] omxh264enc: also use OMX_VIDEO_PARAM_AVCTYPE to set profile and level

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=783862

Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nicolas at ndufresne.ca

--- Comment #6 from Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> ---
(In reply to Guillaume Desmottes from comment #5)
> (In reply to Nicolas Dufresne (stormer) from comment #4)
> > Review of attachment 353893 [details] [review] [review]:
> > 
> > You need to initialize the structure with valid defaults (not just the
> > profile and level), otherwise none of the Android component will work. Its
> > not standard, but it would make this patch more useful.
> 
> Shouldn't the get_parameter() call initialize those?

I think so, but Android component generally don't because Android generic code
will do that already. In anycase, it makes the behaviour more consistent, as
we'll rely on the same defaults everywhere instead of random defaults per
component. What I got in my dirty branch, copied from Android code:

https://paste.fedoraproject.org/paste/PwgMWes5qD1ONVMYrUJnjQ

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.