[Bug 783955] mpegpsmux: caps leak and invalid return

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=783955

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #354035|none                        |reviewed
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 354035:
 --> (https://bugzilla.gnome.org/review?bug=783955&attachment=354035)

::: gst/mpegpsmux/mpegpsmux.c
@@ -231,2 @@
   s = gst_caps_get_structure (caps, 0);
-  g_return_val_if_fail (s != NULL, FALSE);

How were you able to make this assertion happen? It looks like this code can't
ever happen unless something is really wrong elsewhere already... in which case
the caps leak is probably the least of the problems.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.