[Bug 732265] vaapidecode: h264: add support for decoding MVC base views only

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=732265

--- Comment #5 from Orestis Floros <orestisf1993 at gmail.com> ---
Review of attachment 354073:
 --> (https://bugzilla.gnome.org/review?bug=732265&attachment=354073)

::: gst-libs/gst/vaapi/gstvaapidecoder_h264.c
@@ +4668,3 @@
+      case GST_H264_NAL_SUBSET_SPS:
+      case GST_H264_NAL_SLICE_EXT:
+        flags |= GST_VAAPI_DECODER_UNIT_FLAG_SKIP;

This actually causes multiple (harmless) errors with a
stream-format=byte-stream and alignment=nal pipeline. The sps != NULL assertion
in decode_picture() fails.

Removing this part avoids that while the result doesn't change. Don't know if I
should correct that or not set the GST_VAAPI_DECODER_UNIT_FLAG_SKIP flag at
all.

Tested with pipeline:
filesrc location=a.ts ! tsdemux ! h264parse ! vaapih264dec base-only=TRUE !
fakesink

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.