[Bug 783842] [REGRESSION] encodebin: Transcoding of several media streams (to h264 in mp4) fail

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=783842

--- Comment #6 from Thibault Saunier <tsaunier at gnome.org> ---
(In reply to Tim-Philipp Müller from comment #5)
> Review of attachment 353917 [details] [review]:
> 
> Looking at the code it seems like someone went to a lot of trouble to not do
> exactly this - did anyone investigate what the reason for that is?

If by investigate you mean bisect that exact line, I did, but nothing
conclusive, it seems to appear in:

commit a40b993bc347ceb99e831a2c91f44f6887eebbb6
Author: Mark Nauwelaerts <mark.nauwelaerts at collabora.co.uk>
Date:   Tue Feb 14 19:33:50 2012 +0100

     baseparse: remove dead code and superfluous loop level

which is does not give any useful information :-)

Apart from that, as previously stated, I do not really understand that code and
was showing that patch rather in order to get input about it than getting it
in.

tbh, I think we might probably want to revert that commit in encodebin if no
one is making any case for keeping it.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.