[Bug 777825] isoff: Move isoff to gst-libs

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=777825

Reynaldo H. Verdejo Pinochet <reynaldo at osg.samsung.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #353136|none                        |accepted-commit_now
             status|                            |

--- Comment #42 from Reynaldo H. Verdejo Pinochet <reynaldo at osg.samsung.com> ---
Review of attachment 353136:
 --> (https://bugzilla.gnome.org/review?bug=777825&attachment=353136)

(In reply to Seungha Yang from comment #37)
> 
> Always thanks for your detailed review :) 
> 


Thanks for keeping up with it!


> I'd like to ask and answer about your suggestion
> 
> * About version handling,
> I prefer to use if/else instead of switch because
> - ISO/IEC 14496-12:2015 is defining like if/else and qtdemux also did it.
> So I'd like to make them similar. In my opinion, defining more version is
> not probable in near future.


Famous last words :D but It's no biggie. Leave it as it is.


> [..] 
> In this context, could you please inform more detail about following comment?
> > There's no need for two $had_ variables. Use only one and consider making the > function return the found value instead of a boolean if you think it's useful.
> > ...

I meant that your logic can be reproduced with only one variable. But it's OK,
your version is actually clearer. On the function's return, I was suggesting
using it to return information on what was actually missing.

New version looks good to go.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.