[Bug 770107] qtdemux: reports only one encryption system even if it can support more than one

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Thu Jun 22 11:04:50 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=770107

Xabier Rodríguez Calvar <calvaris at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #352311|0                           |1
        is obsolete|                            |

--- Comment #25 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Created attachment 354242
  --> https://bugzilla.gnome.org/attachment.cgi?id=354242&action=edit
2/3 qtdemux: add context for a preferred protection (review suggestions
applied)

I reworked the patch to make it more efficient since there were some checks
that had sense before but they don't since we are going to try what is
preferred by the context even it wasn't reported as encryption system by the
media. I also fixed the case about not having a recommendation from the app
that was ending in an error. As it is now:

1- runs the context query if no context was set to the demuxer with all the
encryption information found on the media
2- checks if there's a decryptor for the preferred encryption system if any. If
it can find the decryptor, ok, if it can't then it warns
3- if there is no preferred selected system, it runs the old algorithm to keep
the same behavior that it had so far

According to our last conversations with Tim during the hackfest, this would
"landable" as it is now.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list