[Bug 757941] vaapiencode: Allow to set profiles via capsfilters

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=757941

--- Comment #26 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
(In reply to Hyunjun Ko from comment #23)
> I'm testing current 4 patches.
> The second patch implemented by myself causes a problem when profile is
> changed.
> 
> Test pipeline:
> gst-launch-1.0 videotestsrc num-buffers=100 !
> video/x-raw,width=1920,height=1080 ! vaapih264enc !
> video/x-h264,profile=baseline ! mp4mux ! fakesink
> 
> In this pipeline, it changes profile from baseline to constrained-baseline,
> which is correct. But it fails to push the first frame due to
> "not-negotiated"

Does the pipeline return a "not-negotiated" error?

That might be a correct behavior... isn't it?

> probably because it's already negotiated with profile=baseline.
> Previously this was working with using constrained-baseline profile without
> changing profile in src caps .
> 
> What I'm thinking is
> - Is this right that encoder is working without changing profile of caps?
>  -> I don't think so, that's why we're trying to fix this issue!
> - Then how can we fix this case?
>  -> we should try to negotiate with updated profile at set_format.

mmmh... it makes sense.

> 
> What do you think?...again :)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.