[Bug 784132] rtpmanager: Add support for in-band synchronization (RFC 6051).

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=784132

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #354324|none                        |reviewed
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 354324:
 --> (https://bugzilla.gnome.org/review?bug=784132&attachment=354324)

No full review yet, just some comments. It seems useful to (also) add this in
rtpbin somewhere if the payloader did not do it yet

::: gst-libs/gst/rtp/gstrtpbasepayload.c
@@ +1285,3 @@
+  if (G_UNLIKELY (!GST_CLOCK_TIME_IS_VALID (priv->base_ntptime))) {
+    guint64 running_time;
+    get_current_times (payload, &running_time, &priv->base_ntptime);

This seems wrong for running_time/clock_time. You probably want to calculate it
based on the running time of the buffer PTS instead of taking the clock
directly.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.