[Bug 784132] rtpmanager: Add support for in-band synchronization (RFC 6051).

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=784132

--- Comment #5 from GstBlub <gstblub at gmail.com> ---
(In reply to Sebastian Dröge (slomo) from comment #2)
> Review of attachment 354324 [details] [review]:
> 
> No full review yet, just some comments. It seems useful to (also) add this
> in rtpbin somewhere if the payloader did not do it yet
> 
> ::: gst-libs/gst/rtp/gstrtpbasepayload.c
> @@ +1285,3 @@
> +  if (G_UNLIKELY (!GST_CLOCK_TIME_IS_VALID (priv->base_ntptime))) {
> +    guint64 running_time;
> +    get_current_times (payload, &running_time, &priv->base_ntptime);
> 
> This seems wrong for running_time/clock_time. You probably want to calculate
> it based on the running time of the buffer PTS instead of taking the clock
> directly.

I'm not sure what you mean.  I do need an actual timestamp provided by a clock
(ntp).  I cannot derive a "ntp" time from the PTS.  I then take these
timestamps and use those in the RTCP SR packets rather than querying the clock
there, which ensures that the direct relationship between ntp timestamp and rtp
timestamp is maintained.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.