[Bug 784302] v4l2allocator leak when dmabuf creation fails

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=784302

Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #354643|none                        |needs-work
             status|                            |

--- Comment #3 from Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> ---
Review of attachment 354643:
 --> (https://bugzilla.gnome.org/review?bug=784302&attachment=354643)

::: sys/v4l2/gstv4l2allocator.c
@@ +922,3 @@
 cleanup:
   {
+    gst_object_unref (allocator);

I'm not sure if it's fully correct, the leak is in fact cause by the fact the
we leave before we increment mems_allocated. I think the right solution is just
to move "group->mems_allocated++;" right after:

>      /* Take back the allocator reference */
>      gst_object_ref (allocator);
>    }

-> HERE

Would you mind testing it ? Otherwise you also leak the GstMemory object.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.